-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add Dash Club snippet #3839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dash Club snippet #3839
Conversation
Hi @LiamConnors |
Can I see a screenshot/mockup of what you're trying to do with this? There may be an easier site-wide way of doing this. |
@nicolaskruchten sure. It's the snippet that we already have in the Dash docs. Like on this page: And we want to put it on the top 100 pages, near the Dash content on those pages. |
@LiamConnors can you please share a screenshot of what this looks like in the docs. |
@Coding-with-Adam it looks like this: We could also maybe instead add it to the What About Dash section at the end of each page? As What About Dash is just one Markdown file that's added to each page when it's being built, it would be much quicker to get this snippet appearing on all pages and would be much easier to manage when we want to make changes. |
Hi @LiamConnors, When you say "it would be much quicker to get this snippet appearing on all pages", you mean that having the snippet outside the |
@Coding-with-Adam, apologies, I meant it would be easier to implement and maintain. I see your point about it being too far down the page. What do you think about having it just below the Dash app example? If we were put it below the Dash app example, maybe we could just add it to the Dash Snippet app itself. Do you see any issues with that approach @nicolaskruchten? I couldn't see any other straightforward way to implement this across the site. But if we add it to the app container (assuming that placement is okay with @Coding-with-Adam) we'd only have to update it in one place to get it on all those pages that have a Dash app. |
Hi @LiamConnors
|
@Coding-with-Adam, I was thinking right below the running example
Updated
Updated I've added the snippet to the pages that have Dash examples. It looks like this: For pages that don't have a Dash example or mention of Dash, where do you think it should go? |
Thank you @LiamConnors . We're good to go. I just talked to Chris and he liked the placement and wording as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃🏼
@Coding-with-Adam, as requested, this adds the Dash Club snippet that we already have on the Dash docs. Adds it to the ten most popular pages here to get started.