Skip to content

start orca with --no-sandbox flag #2298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

start orca with --no-sandbox flag #2298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41ba2af
run orca with --no-sandbox flag
antoinerg Mar 20, 2020
2686608
update baseline for Orca 1.3.0
antoinerg Mar 20, 2020
90f3193
pin orca==1.3.0
antoinerg Mar 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/create_conda_optional_env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ if [ ! -d $HOME/miniconda/envs/circle_optional ]; then
requests nbformat six retrying psutil pandas decorator pytest mock nose poppler xarray scikit-image ipython jupyter ipykernel ipywidgets

# Install orca into environment
$HOME/miniconda/bin/conda install --yes -n circle_optional -c plotly plotly-orca
$HOME/miniconda/bin/conda install --yes -n circle_optional -c plotly plotly-orca==1.3.0
fi
7 changes: 5 additions & 2 deletions packages/python/plotly/plotly/io/_orca.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1142,7 +1142,9 @@ def validate_executable():
# ### Run with Popen so we get access to stdout and stderr
with orca_env():
p = subprocess.Popen(
executable_list + ["--help"], stdout=subprocess.PIPE, stderr=subprocess.PIPE
executable_list + ["--no-sandbox", "--help"],
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
)

help_result, help_error = p.communicate()
Expand Down Expand Up @@ -1212,7 +1214,7 @@ def validate_executable():
# ### Run with Popen so we get access to stdout and stderr
with orca_env():
p = subprocess.Popen(
executable_list + ["--version"],
executable_list + ["--no-sandbox", "--version"],
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
)
Expand Down Expand Up @@ -1406,6 +1408,7 @@ def ensure_server():

# Build orca command list
cmd_list = status._props["executable_list"] + [
"--no-sandbox",
"serve",
"-p",
str(orca_state["port"]),
Expand Down
2,723 changes: 1,241 additions & 1,482 deletions packages/python/plotly/plotly/tests/test_orca/images/linux/failed/fig1.eps
View file
Open in desktop

Large diffs are not rendered by default.

2,405 changes: 1,199 additions & 1,206 deletions packages/python/plotly/plotly/tests/test_orca/images/linux/fig1.eps
View file
Open in desktop

Large diffs are not rendered by default.

4,696 changes: 3,874 additions & 822 deletions packages/python/plotly/plotly/tests/test_orca/images/linux/latexfig.eps
View file
Open in desktop

Large diffs are not rendered by default.

9,663 changes: 7,954 additions & 1,709 deletions packages/python/plotly/plotly/tests/test_orca/images/linux/topofig.eps
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions packages/python/plotly/plotly/tests/test_orca/test_orca_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ def test_external_server_url():
# Build external orca command
orca_path = which("orca")
cmd_list = [orca_path] + [
"--no-sandbox",
"serve",
"-p",
str(port),
Expand Down