Skip to content

add examples for customizing marker symbols #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 19, 2020
Merged

Conversation

jdamiba
Copy link

@jdamiba jdamiba commented Feb 14, 2020

supersedes #2188 due to merge conflict issues

closes #2182

@jdamiba jdamiba requested a review from emmanuelle February 14, 2020 17:33
@jdamiba jdamiba changed the base branch from master to doc-prod February 14, 2020 17:34
@emmanuelle
Copy link
Contributor

Thanks @jdamiba 💃 !

@emmanuelle
Copy link
Contributor

Just two more comments from @nicolaskruchten

@jdamiba
Copy link
Author

jdamiba commented Feb 17, 2020

@emmanuelle I have updated this PR with some of the styling suggestions that were made by @nicolas. Would love to get your opinion! FYI, we decided that it didn't look good to have the names of the symbols for the custom example always visible.
Screen Shot 2020-02-17 at 2 16 25 PM
Screen Shot 2020-02-17 at 2 16 13 PM

@jdamiba jdamiba merged commit c44eb6b into doc-prod Feb 19, 2020
@jdamiba jdamiba deleted the marker-symbols branch February 19, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add symbol types to the marker style chapter
2 participants