Template bis #1893
Merged
Template bis #1893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. The changes in the percy tests all look like improvements. And the chart studio test failure is unrelated so 💃 from me. |
|
@jonmmease please bear with me I just pushed another commit with also pie automargin. Waiting for percy to run... If eveything is well I should be done |
|
great. looks like the chart studio tests are passing now. Just a black formatting issue left |
|
This change moves the titles a bit closer to the tick labels by default, which I’m ok with. Maybe in some near future we can have the built in templates reduce the margins a bit too :) |
|
thanks Jon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.