Skip to content

Update contribution guidelines #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 10, 2019
Merged

Conversation

joelostblom
Copy link
Contributor

I was setting up a plotly dev env again and documented a few things I did differently from the current guidelines. The only thing that I didn't include was that I had issues installing the optional dependencies via pip. This might be a local problem, but fwiw I installed these packages via conda instead:

conda create -n plotly-dev pandas seaborn jupyterlab scipy simplegeneric
conda activate plotly-dev
conda install -c plotly plotly-orca psutil requests

@emmanuelle
Copy link
Contributor

Thanks @joelostblom. I think most people take a look at this info on github, so is it OK if we review/merge after 4.3?

@jonmmease
Copy link
Contributor

Thanks @joelostblom! I'm going to merge this and then add a follow-up commit removing the submodules section now that these are all inlined (as of #1942)

@jonmmease jonmmease merged commit d8b9fc2 into plotly:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants