Widgets update syntax #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make docstream copy pasteable; fix parentheses
Though these requirements are unecessary for Python versions after 2.6, they’re small, harmless libs to import. They ended up being included in stdlib anyways.
Add strict requirements for python 2.6. (more)
All of our messages seem to be being sent twice! Not sure where that’s coming from. This is a temporary fix that synced with the new frontend postMessage hopefully we can revert this.
|
Note, this is merging into the |
7 tasks
Now each `graph` remembers the domain it was created with.
Conflicts: plotly/widgets/graph_widget.py
|
@chriddyp , the new syntax is on prod now. You'll need to merge in these changes to the widgets branch for your stuff to work (feel free to do so!) Note, the syntax changed a bit, see here for new variable names: https://github.com/plotly/streambed/blob/master/shelly/embedplot/static/embedplot/main.js#L313-341 And see take a peek in graph_widget.py as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chriddyp , this is the new (perhaps still-in-flux) syntax for postMessage.
I also include a fix for doubly sent messages to the iframe. Not sure where that was coming from, but this is a cheap fix that got me to where i needed to be with testing functionality.