Merge plotlywidget and @jupyterlab/plotly-extension extensions

[timkpaine]

It would be helpful to merge these and keep them in sync under a single authority. Beakerx has a good example of exposing both widget and mimerender extensions, we can work from that - package.json and code.

[timkpaine]

@jonmmease and @gnestor

[gnestor]

I'm ok with that if @jonmmease wants to merge plotly-extension into plotlywidget (and move the code into https://github.com/plotly/plotly.py/tree/master/js)

[jonmmease]

Thanks for the suggest @timkpaine, I totally agree. And I think this is in scope for v4. Thanks for digging up the BeakerX example as a reference.

I'm wondering how far to take this, should we also consider merging in the JupyterLab chart editor? Should all of the extensions we manage that have a dependency on plotly.js become a single extension?

I don't have a good sense on the bundle size considerations of this yet. Regardless, we should also look into loading the plotly.js bundle lazily so as not to weigh down JupyterLab when plotly stuff isn't in use.

[timkpaine]

@jonmmease yeah I think that all makes sense

[gnestor]

I don't think we should combine them all into the same extension but we could move them all into the same monorepo.

[timkpaine]

@gnestor that would also be fine, the main concern is they should all update plotlyjs version and plotly/plotlywidget semver in sync.

[jonmmease]

Fun idea from the forums on providing ploty.py with information about the current JupyterLab theme. https://community.plot.ly/t/make-plotly-graphs-automatically-adadpt-to-jupyterlab-theme/21800.

This could be communicated using a simple comm message, and I think it would make sense to include this with this merged extension.

[gnestor]

Ya I like this idea. Would it make more sense to out this theme logic in plotly.js?

[Alexboiboi]

Hi @jonmmease, any news on this topic ?

Also it would be nice if this features also integrates with voilà apps.

[icoert]

Hi @jonmmease, any news on this topic ?

Also it would be nice if this features also integrates with voilà apps.

still.. nothing new?

[nicolaskruchten]

No news yet. We will update this topic when there is some!

That said, we would welcome any assistance in doing this, either in the form of a pull request, or via sponsorship :)

[jonmmease]

I did get as far as a prototype that merged the extensions a while back. It worked fine in JupyterLab, but I didn't see how to do it in a way that wouldn't break the display of FigureWidget in nbviewer and Voilà. As I recall, for these there needs to be an npm package named plotlywidget that contains appropriate metadata.

If we merged them, then we would need to merge the Jupyterlab-specific mimetype renderer (jupyterlab-plotly) into the plotlywidget package without breaking how nbviewer/Voilà automatically load the widget code outside of a JupyterLab context.

Or, maybe we work out a publication workflow to keep publishing a plotlywidget package, but also includes the widget code in jupyterlab-plotly. But, then we'd need to work through a way to prevent the installation of both jupyterlab-plotly and plotlywidget as JupyterLab extensions so that they don't clobber each other.

In any case, I'm sure there's a ways to get everything working, but several points are a bit subtle.

[timkpaine]

Perspective exports both an ipywidget and a mime renderer with no issues in voila:
https://github.com/finos/perspective/blob/master/packages/perspective-jupyterlab/src/ts/index.ts#L29

It requires:
voila-dashboards/voila#481

[nicolaskruchten]

Closed in #3142