Add madge check for circular dependencies on test-syntax #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oooh boy I like this. Reminds me of one of the requirements GHC development has - none of the perf tests they have are allowed to get any slower! 💃 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of work has gone into decircularising the
src/directory (see milestone https://github.com/plotly/plotly.js/milestone/9), so let's (try to) not make it go to waste.Introducing the
madgemodule dependency graph which has a great circular dependencies inspector option.This PR adds a step to the
test-syntaxscript making sure that oursrc/directory never gets more circular than what it is right now onmaster.