Improve docker container reliability #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- by calling testMock inside setTimeout
- rm polar_scatter.json for now (it is showing some run-to-run randomness)
| - docker run -d --name myimageserver -v $PWD:/var/www/streambed/image_server/plotly.js -p 9010:9010 plotly/imageserver:latest; sleep 20 | ||
|
|
||
| - docker run -d --name myimageserver -v $PWD:/var/www/streambed/image_server/plotly.js -p 9010:9010 plotly/imageserver:candidate | ||
| - wget --server-response --spider --tries=8 --retry-connrefused http://localhost:9010/ping |
There was a problem hiding this comment.
wait until image server returns a pong before starting the tests.
|
Robust CircleCI testing:
|
|
💃 for docker related part ;D |
| - docker run -d --name myimageserver -v $PWD:/var/www/streambed/image_server/plotly.js -p 9010:9010 plotly/imageserver:latest; sleep 20 | ||
|
|
||
| - docker run -d --name myimageserver -v $PWD:/var/www/streambed/image_server/plotly.js -p 9010:9010 plotly/imageserver:latest | ||
| - wget --server-response --spider --tries=8 --retry-connrefused http://localhost:9010/ping |
There was a problem hiding this comment.
An even better script would restart nw1 if the image server doesn't return a pong after 8 tries.
Looks like the latest container is reliable enough that we don't need this now. But, maybe later.
|
Let's issue up those missed mocks and link to them in the script. Once that is in place it looks 💃 to me! |
|
Blind as a bat! Great 💃 |
etpinard
added a commit
that referenced
this pull request
Dec 8, 2015
Improve docker container reliability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@perigee @mdtusz @alexcjohnson @bpostlethwaite @cldougl
This PR does not fix #62 and some local issues (ask @mdtusz 😺 ), but removes a significant amount of test-to-test randomness in the image test suite --- especially on CircleCI.