Skip to content

fix ternary hover after zoom/pan events #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 27, 2016
Merged

fix ternary hover after zoom/pan events #688

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3b1ee6b
fix ternary hover after zoom/pan events
alexcjohnson Jun 24, 2016
ab3a9a2
Tests: pull click and doubleClick out into assets
alexcjohnson Jun 24, 2016
cda7f6c
appease eslint
alexcjohnson Jun 24, 2016
c45c074
hover on fills: constrain label to cartesian and ternary viewports
alexcjohnson Jun 24, 2016
a0a12d8
test clipped positioning of hover labels for scatterternary fill
alexcjohnson Jun 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/jasmine/assets/click.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ module.exports = function click(x, y) {
mouseEvent('mousemove', x, y);
mouseEvent('mousedown', x, y);
mouseEvent('mouseup', x, y);
};
};
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etpinard per my commit message... somehow eslint run through sublime cannot sort out the config files within the jasmine directory, even though as far as I can tell it's all correct. In any other directory things look fine. Have you seen this? If I change test/jasmine/.eslintrc from "extends": "../../.eslintrc" to "extends": "../.eslintrc" it no longer complains, though that's clearly not what you want as it'll think node is allowed.

I suppose we could make that change and also explicitly set env.node=false, that seems to work for me, but it's strange that this would be necessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. No, I've never seen that one before.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking it may be worth moving all our .eslintrc in a config/ at the root of the repo instead of having them scattered around (and hidden in) the directory tree.

We could move test_syntax.js to tasks/.

Having

test/
  |
  - image/
  - jasmine/
  - test_syntax.js
  - .eslintrc  (which is only relevant for test_syntax.js)

isn't great.

2 changes: 1 addition & 1 deletion test/jasmine/assets/double_click.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ module.exports = function doubleClick(x, y) {
setTimeout(function() { resolve(); }, DBLCLICKDELAY / 2);
}, DBLCLICKDELAY / 2);
});
};
};
2 changes: 0 additions & 2 deletions test/jasmine/tests/select_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ var d3 = require('d3');

var Plotly = require('@lib/index');
var Lib = require('@src/lib');
var DBLCLICKDELAY = require('@src/plots/cartesian/constants').DBLCLICKDELAY;
var click = require('../assets/click');
var doubleClick = require('../assets/double_click');

var createGraphDiv = require('../assets/create_graph_div');
Expand Down