Skip to content

Better image testing docs #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 4, 2015
Merged

Better image testing docs #67

merged 3 commits into from
Dec 4, 2015

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Dec 3, 2015

@perigee @alexcjohnson @cldougl @mdtusz

Better dockers docs, including info about docker-machine for Mac users.

Set up the docker environment for `docker-compose`:

```bash
eval $(docker-machine env default)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexcjohnson this should do the trick.

Reference: docker/compose#2180 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexcjohnson @cldougl what version of docker-compose are you using?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker-compose version: 1.5.1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, the eval did it for me. (I used it with quotes, as mentioned within the output of docker-machine env default itself)
Image tests work locally for me now! Well almost, some intermittent gl3d errors (gl3d_marker-color.png failed twice in a row, gl3d_mirror-ticks.png failed one of two times)

Does it save the images it makes somewhere when they fail?

Version: 1.5.1, just like @cldougl (installed today)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it save the images it makes somewhere when they fail?

Yes, look into build/test_images and `build/test_images_diff``.

Or even better, run npm run start-image_viewer to view the baseline, generated image, diff and mock side by side.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good shell function to add to your rc file if you have lots of docker-machines (I have like 8 that I use depending) is this.

@mdtusz
Copy link
Contributor

mdtusz commented Dec 3, 2015

Looks ok to me.

Fun little oneliner for when you've got a lot of docker containers still that you want to remove:

docker ps -aq | xargs docker rm -f

💃

@cldougl
Copy link
Member

cldougl commented Dec 3, 2015

👍 from me too! 🐳 🐳 🐳

@etpinard
Copy link
Contributor Author

etpinard commented Dec 4, 2015

@perigee I'm going to merge this knowing that the updated instructions are working on @cldougl and @alexcjohnson Macs.

etpinard added a commit that referenced this pull request Dec 4, 2015
@etpinard etpinard merged commit 7c33004 into master Dec 4, 2015
@etpinard etpinard deleted the etpinard-patch-1 branch December 4, 2015 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants