-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Better image testing docs #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Set up the docker environment for `docker-compose`: | ||
|
||
```bash | ||
eval $(docker-machine env default) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexcjohnson this should do the trick.
Reference: docker/compose#2180 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexcjohnson @cldougl what version of docker-compose
are you using?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker-compose version: 1.5.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, the eval did it for me. (I used it with quotes, as mentioned within the output of docker-machine env default
itself)
Image tests work locally for me now! Well almost, some intermittent gl3d errors (gl3d_marker-color.png
failed twice in a row, gl3d_mirror-ticks.png
failed one of two times)
Does it save the images it makes somewhere when they fail?
Version: 1.5.1, just like @cldougl (installed today)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it save the images it makes somewhere when they fail?
Yes, look into build/test_images
and `build/test_images_diff``.
Or even better, run npm run start-image_viewer
to view the baseline, generated image, diff and mock side by side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good shell function to add to your rc file if you have lots of docker-machines (I have like 8 that I use depending) is this.
Looks ok to me. Fun little oneliner for when you've got a lot of docker containers still that you want to remove:
💃 |
👍 from me too! 🐳 🐳 🐳 |
@perigee I'm going to merge this knowing that the updated instructions are working on @cldougl and @alexcjohnson Macs. |
@perigee @alexcjohnson @cldougl @mdtusz
Better dockers docs, including info about
docker-machine
for Mac users.