Skip to content

new mapbox token for testing #6610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2023
Merged

new mapbox token for testing #6610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc82f57
new mapbox token for testing
archmoj May 23, 2023
6fcbcb9
temp fix for mapbox_custom-style
archmoj May 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tasks/noci_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ test_image () {
$root/test/image/mocks/mapbox_density0-legend.json \
--mathjax $root/node_modules/mathjax-v2/MathJax.js \
--plotly $root/build/plotly.js \
--mapbox-access-token "pk.eyJ1IjoicGxvdGx5LWpzLXRlc3RzIiwiYSI6ImNrNG9meTJmOTAxa3UzZm10dWdteDQ2eWMifQ.2REjOFyIrleMqwS8H8y1-A" \
--mapbox-access-token "pk.eyJ1IjoicGxvdGx5LWRvY3MiLCJhIjoiY2xpMGYyNWgxMGJhdzNzbXhtNGI0Nnk0aSJ9.0oBvi_UUZ0O1N0xk0yfRwg" \
--output-dir $root/test/image/baselines/ \
--verbose || EXIT_STATE=$?
}
Expand Down
2 changes: 1 addition & 1 deletion tasks/util/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ module.exports = {

// this mapbox access token is 'public', no need to hide it
// more info: https://www.mapbox.com/help/define-access-token/
mapboxAccessToken: 'pk.eyJ1IjoicGxvdGx5LWpzLXRlc3RzIiwiYSI6ImNrNG9meTJmOTAxa3UzZm10dWdteDQ2eWMifQ.2REjOFyIrleMqwS8H8y1-A',
mapboxAccessToken: 'pk.eyJ1IjoicGxvdGx5LWRvY3MiLCJhIjoiY2xpMGYyNWgxMGJhdzNzbXhtNGI0Nnk0aSJ9.0oBvi_UUZ0O1N0xk0yfRwg',
pathToCredentials: path.join(pathToBuild, 'credentials.json'),

testContainerImage: 'plotly/testbed:latest',
Expand Down
3 changes: 3 additions & 0 deletions test/image/compare_pixels_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ argv._.forEach(function(pattern) {
}
});

// skip for now | TODO: figure out why needed this in https://github.com/plotly/plotly.js/pull/6610
allMockList = allMockList.filter(function(a) { return a !== 'mapbox_custom-style';});

if(mathjax3) {
allMockList = [
'legend_mathjax_title_and_items',
Expand Down
3 changes: 2 additions & 1 deletion test/image/make_baseline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@
# unable to generate baselines for the following mocks
blacklist = [
'mapbox_density0-legend',
'mapbox_osm-style'
'mapbox_osm-style',
'mapbox_custom-style' # Figure out why needed this in https://github.com/plotly/plotly.js/pull/6610
]
allNames = [a for a in allNames if a not in blacklist]

Expand Down
2 changes: 1 addition & 1 deletion test/jasmine/tests/mapbox_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ describe('mapbox credentials', function() {
});
}, LONG_TIMEOUT_INTERVAL);

it('@gl should not throw when using a custom mapbox style URL with an access token in the layout', function(done) {
it('@noCI @gl should not throw when using a custom mapbox style URL with an access token in the layout', function(done) {
var cnt = 0;

Plotly.newPlot(gd, [{
Expand Down