Skip to content

Fix flaky sankey #6317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2022
Merged

Fix flaky sankey #6317

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b815f31
Fix flaky sankey test
hannahker Sep 12, 2022
606e67c
Remove from flaky tests
hannahker Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/jasmine/tests/sankey_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1318,7 +1318,7 @@ describe('sankey tests', function() {
.then(done, done.fail);
});

it('@flaky should persist the position of every nodes after drag in attributes nodes.(x|y)', function(done) {
it('should persist the position of every nodes after drag in attributes nodes.(x|y)', function(done) {
mockCopy.data[0].arrangement = arrangement;
var move = [50, -50];
var nodes;
Expand Down Expand Up @@ -1346,7 +1346,7 @@ describe('sankey tests', function() {

nodes = document.getElementsByClassName('sankey-node');
node = nodes.item(nodes.length - 1); // Dragged node is now the last one
return drag({node: node, dpos: move});
return drag({node: node, dpos: move, timeDelay: arrangement === 'snap' ? 200 : 0}); // Wait for animation to finish
})
.then(function() {
x1 = gd._fullData[0].node.x.slice();
Expand Down