Skip to content

Fixup relayout images in { astr: val } notation #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2016

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Jun 9, 2016

@mdtusz

For example,

Plotly.relayout(gd, { 'images[0].x': 0, 'images[0].y': 1 });

is broken currently.

The fix was easy ... once I made sense of all those tiny relayout variable names.

@etpinard etpinard added bug something broken status: reviewable labels Jun 9, 2016
@etpinard etpinard force-pushed the fixup-relayout-images branch from 43ddafb to fd659f2 Compare June 10, 2016 01:52
@mdtusz
Copy link
Contributor

mdtusz commented Jun 10, 2016

Yep. Lots of aobj, ai, pleaf, pleafplus things in there.

💃

@etpinard etpinard merged commit bcde048 into master Jun 10, 2016
@etpinard etpinard deleted the fixup-relayout-images branch June 10, 2016 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants