fix gl2d replot #570
Merged
fix gl2d replot #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- so that Plots.getSubplots('gl2d' or 'cartesian') does not fail
on a blank (i.e. Plotly.plot(gd, [])) plot
- I am beginning to doubt that storing both 'cartesian' and 'gl2d'
subplot objects in fullLayout._plots is the way to go.
- delete old 2d scenes that don't nest any 'gl2d' traces, instead of deleting 2d scenes that have no corresp. axes in new fullLayout. - delete item in _plots, so that if a 'gl2d' -> 'cartesian' subplot conversion happens unhindered.
| it('should be able to replot from a blank graph', function(done) { | ||
| var gd = createGraphDiv(); | ||
|
|
||
| function assert(cnt) { |
There was a problem hiding this comment.
Maybe change the name of this. I know it's not really node code, but at a glance without seeing the function, it could be mistaken for the node assert.
|
Small 🐄 with the naming, then 💃 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mdtusz replotting from a blank graph is currently broken for
gl2dplots.For example,
is falling.
This PR fixes ⏫ , while robustifying the
gl2dclean-plot step and adding a comprehensive test case.