cache values and patterns in set_convert for rangebreaked axis #5659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spasovski
changed the title
archmoj
reviewed
May 14, 2021
dsmmcken
reviewed
May 17, 2021
| }); | ||
| } | ||
|
|
||
|
|
||
| for(var i = 0; i < rangebreaksIn.length; i++) { | ||
| var brk = rangebreaksIn[i]; |
There was a problem hiding this comment.
I would cache against each brk group, instead of the rangebreaks array as whole, lets you get rid of the nulls and puts the cached values immediately adjacent to the raw values.
|
@archmoj please let me know your feedback on this, would love to know if the approach is good or if it needs changes |
|
Thanks @spasovski. |
|
Hi folks please let me know if this approach seems solid. We've been using this in our staging environment for a few weeks and haven't had any issues so far. |
|
Looking good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5630
set_convertcould benefit from caching thesimpleMapresults. My team and I experienced drastic performance issues on ticking plots with rangebreaks. We are quite open to better suggestions though this approach worked quite well for us in testing.