Skip to content

Provide minimal padding for inside tick labels case of bar, heatmap, line plots #5325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 7, 2020
Merged

Provide minimal padding for inside tick labels case of bar, heatmap, line plots #5325

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c5b79ea
provide padding for inside tick labels when not asked for
archmoj Dec 7, 2020
f62f186
rename to pad inside functions
archmoj Dec 7, 2020
f0709c3
rewrite and reduce the number of calls to estimate padding
archmoj Dec 7, 2020
cf68ae7
fixes issue 5321 - more than necessary space
archmoj Dec 7, 2020
85283b5
add text pad around the bounding box
archmoj Dec 7, 2020
2c3298d
add new tests
archmoj Dec 7, 2020
8199d38
fixup axis title position when having inside tick labels
archmoj Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/plots/cartesian/autorange.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,14 +221,18 @@ function makePadFn(ax, max) {
extrappad = adjustPadForInsideLabelsOnAnchorAxis(extrappad, ax, max);
extrappad = adjustPadForInsideLabelsOnThisAxis(extrappad, ax, max);

var pad0 = 0;
pad0 = adjustPadForInsideLabelsOnAnchorAxis(pad0, ax, max);
pad0 = adjustPadForInsideLabelsOnThisAxis(pad0, ax, max);

// domain-constrained axes: base extrappad on the unconstrained
// domain so it's consistent as the domain changes
if((ax.constrain === 'domain') && ax._inputDomain) {
extrappad *= (ax._inputDomain[1] - ax._inputDomain[0]) /
(ax.domain[1] - ax.domain[0]);
}

return function getPad(pt) { return pt.pad + (pt.extrapad ? extrappad : 0); };
return function getPad(pt) { return pt.pad + (pt.extrapad ? extrappad : pad0); };
}

var TEXTPAD = 3;
Expand Down