Skip to content

Validate image_astronaut_source mock #5113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2020
Merged

Validate image_astronaut_source mock #5113

merged 2 commits into from
Sep 1, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Sep 1, 2020

The image API has no x and y attribute which were removed from the mock in b152756.

@plotly/plotly_js

@archmoj archmoj requested a review from antoinerg September 1, 2020 15:04
@antoinerg
Copy link
Contributor

💃

@antoinerg
Copy link
Contributor

antoinerg commented Sep 1, 2020 •
edited
Loading

I meant to put x0 and y0 but since we don't see any axes in the final image, it doesn't make any difference in the end. Thanks @archmoj !

@archmoj archmoj merged commit c437cdf into master Sep 1, 2020
@archmoj archmoj deleted the validate-image_astronaut_source-mock branch September 1, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoinerg antoinerg Awaiting requested review from antoinerg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @antoinerg