Skip to content

Improve monthly period label positioning #5088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Aug 19, 2020

Addressing #5062 (comment)
cc #4911 and #4993 so that the labels position nicely at the middle of uneven months.

Before vs After

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Aug 19, 2020
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yep, that's definitely better 💃

@archmoj archmoj merged commit 979596e into master Aug 19, 2020
@archmoj archmoj deleted the improve-monthly-period-positioning branch August 19, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants