add save and edit icon to modebar #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cldougl
commented
Nov 16, 2015
cldougl
commented
- add icon to save and edit chart in modebar
|
@cldougl - can you make sure that this works from the ipython environment? (I'm sure that it does) |
| @@ -336,43 +336,15 @@ function positionPlayWithData(gd, container){ | |||
| var link = container.append('a') | |||
| .attr({ | |||
| 'xlink:xlink:href': '#', | |||
|
|
|||
|
@cldougl a couple 🐄 then let's merge this in. |
|
Oh right. I just remember we'll need to change the default config so that the 'Edit chart' isn't there by default. https://github.com/plotly/plotly.js/blob/master/src/plot_api/plot_config.js#L38 should be |
cldougl
added a commit
that referenced
this pull request
Nov 16, 2015
add save and edit icon to modebar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.