Skip to content

Revert "expose parcoords context line color" #4650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2020
Merged

Revert "expose parcoords context line color" #4650

merged 1 commit into from
Mar 16, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Mar 16, 2020

Reverts #4635,
noting that the Q&A related to this feature was not inculded in the v1.53.0 milestone.

@plotly/plotly_js

alexcjohnson
alexcjohnson approved these changes Mar 16, 2020
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@archmoj archmoj merged commit 9072918 into master Mar 16, 2020
@archmoj archmoj deleted the revert-4635-res3939-parcoords-context-line-color branch March 16, 2020 16:15
@nicolaskruchten
Copy link
Contributor

Thanks guys... Actually the parcoords percy artifact did not go away, but I still appreciate not having to worry about "oh is this related to that now?" in this cycle :)

@archmoj
Copy link
Contributor Author

archmoj commented Mar 18, 2020

Thanks guys... Actually the parcoords percy artifact did not go away, but I still appreciate not having to worry about "oh is this related to that now?" in this cycle :)

@nicolaskruchten please feel free to open an issue concerning the bug you noticed.
Thanks.

@vdgodse
Copy link

vdgodse commented May 5, 2021

Reverts #4635,
noting that the Q&A related to this feature was not inculded in the v1.53.0 milestone.

@plotly/plotly_js

Would this be added again in a future release as it's a pain to distinguish between the selected and unselected lines when there are too many?

@nicolaskruchten
Copy link
Contributor

It's something we're interested in, yes, but don't have on our roadmap at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@archmoj @nicolaskruchten @vdgodse @alexcjohnson