Skip to content

devtools: Show diff image first #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2016
Merged

Conversation

n-riesco
Copy link
Contributor

When I'm using the image viewer, I always find myself scrolling to the bottom of the page to find the diff image.

With this PR, the images are shown in the following order: diff, mock and baseline.

@etpinard
Copy link
Contributor

Glad to see that someone else is using the image_viewer.

baseline, test output and diff ordering makes more sense to me. But, I'm ok with changing it as long as me make it clearer.

Maybe we could add a tooltip on mouseover over the images displaying diff, baseline, test image accordingly ?

@n-riesco
Copy link
Contributor Author

I think the tooltip would help, but the issue I was trying to address is that in most cases the diff image is out of view at the bottom of the page (imagine scrolling down each time when you have to go through 80 test failures).

@mdtusz
Copy link
Contributor

mdtusz commented Apr 11, 2016

An idea to make things "fancy" but easy to see would be to have the images cycle in the same position, then allow for a mousover/click on a label to choose a specific image. I frequently find myself opening the baseline and computed images on circle and quickly switching tabs between them to see the differences.

@n-riesco
Copy link
Contributor Author

@etpinard I had forgotten about this PR. Sorry about that.

I've added the image tooltips you suggested and three toggle buttons to hide/show the baseline, test and diff images. In this way, if I'm only interested in the diff images I could hide the baseline and test images.

@etpinard
Copy link
Contributor

@n-riesco looks good. Can you merge the latest master, and push again? We've updated our image-test container this week, which is causing old branches to fail on CircleCI.

@mdtusz
Copy link
Contributor

mdtusz commented May 24, 2016

💃

@mdtusz mdtusz merged commit b5331e3 into plotly:master May 24, 2016
@n-riesco n-riesco deleted the image-viewer branch May 25, 2016 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants