Skip to content

Bug fix parcoords when all the data is zero #4082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 26, 2019
Merged

Bug fix parcoords when all the data is zero #4082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
765ca5a
avoid log 0
archmoj Jul 26, 2019
f96d43d
add new test to lock issue 4080
archmoj Jul 26, 2019
fde0d32
add extra check for parcoords ranges
archmoj Jul 26, 2019
096ed73
revert commit 765ca5a62b88eb94bf64dfe32f1eb364d5aff0cb
archmoj Jul 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/plots/cartesian/axes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -840,7 +840,6 @@ function autoTickRound(ax) {
ax._tickround = 2 - Math.floor(Math.log(dtick) / Math.LN10 + 0.01);

var maxend = Math.max(Math.abs(rng[0]), Math.abs(rng[1]));

var rangeexp = Math.floor(Math.log(maxend) / Math.LN10 + 0.01);
if(Math.abs(rangeexp) > 3) {
if(isSIFormat(ax.exponentformat) && !beyondSI(rangeexp)) {
Expand Down
24 changes: 16 additions & 8 deletions src/traces/parcoords/parcoords.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,20 @@ function findExtreme(fn, values, len) {
}

function findExtremes(values, len) {
return [
return fixExtremes(
findExtreme(Math.min, values, len),
findExtreme(Math.max, values, len)
];
);
}

function dimensionExtent(dimension) {
var range = dimension.range;
if(!range) range = findExtremes(dimension.values, dimension._length);

var lo = range[0];
var hi = range[1];
return range ?
fixExtremes(range[0], range[1]) :
findExtremes(dimension.values, dimension._length);
}

function fixExtremes(lo, hi) {
if(isNaN(lo) || !isFinite(lo)) {
lo = 0;
}
Expand Down Expand Up @@ -404,8 +405,15 @@ function calcAllTicks(cd) {
var dim = dimensions[k]._ax;

if(dim) {
if(!dim.range) dim.range = findExtremes(values, trace._length);
if(!dim.dtick) dim.dtick = 0.01 * (Math.abs(dim.range[1] - dim.range[0]) || 1);
if(!dim.range) {
dim.range = findExtremes(values, trace._length);
} else {
dim.range = fixExtremes(dim.range[0], dim.range[1]);
}

if(!dim.dtick) {
dim.dtick = 0.01 * (Math.abs(dim.range[1] - dim.range[0]) || 1);
}

dim.tickformat = dimensions[k].tickformat;
Axes.calcTicks(dim);
Expand Down
43 changes: 31 additions & 12 deletions test/jasmine/tests/parcoords_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ describe('parcoords edge cases', function() {

it('@gl Works fine with one panel only', function(done) {
var mockCopy = Lib.extendDeep({}, mock2);
Plotly.plot(gd, mockCopy.data, mockCopy.layout).then(function() {
Plotly.plot(gd, mockCopy).then(function() {
expect(gd.data.length).toEqual(1);
expect(gd.data[0].dimensions.length).toEqual(2);
expect(document.querySelectorAll('.axis').length).toEqual(2);
Expand All @@ -378,7 +378,7 @@ describe('parcoords edge cases', function() {

it('@gl Do something sensible if there is no panel i.e. dimension count is less than 2', function(done) {
var mockCopy = Lib.extendDeep({}, mock1);
Plotly.plot(gd, mockCopy.data, mockCopy.layout).then(function() {
Plotly.plot(gd, mockCopy).then(function() {
expect(gd.data.length).toEqual(1);
expect(gd.data[0].dimensions.length).toEqual(1);
expect(document.querySelectorAll('.axis').length).toEqual(1); // sole axis still shows up
Expand All @@ -395,7 +395,7 @@ describe('parcoords edge cases', function() {
it('@gl Does not error with zero dimensions', function(done) {
var mockCopy = Lib.extendDeep({}, mock0);

Plotly.plot(gd, mockCopy.data, mockCopy.layout).then(function() {
Plotly.plot(gd, mockCopy).then(function() {
expect(gd.data.length).toEqual(1);
expect(gd.data[0].dimensions.length).toEqual(0);
expect(document.querySelectorAll('.axis').length).toEqual(0);
Expand All @@ -404,13 +404,32 @@ describe('parcoords edge cases', function() {
.then(done);
});

it('@gl Does not error with dimensions including only 0', function(done) {
Plotly.plot(gd, {
data: [{
type: 'parcoords',
dimensions: [{
label: 'all zero',
values: [0, 0]
}]
}],
layout: {}
}).then(function() {
expect(gd.data.length).toEqual(1);
expect(gd.data[0].dimensions.length).toEqual(1);
expect(document.querySelectorAll('.axis').length).toEqual(1);
})
.catch(failTest)
.then(done);
});

it('@gl Works with duplicate dimension labels', function(done) {
var mockCopy = Lib.extendDeep({}, mock2);

mockCopy.layout.width = 320;
mockCopy.data[0].dimensions[1].label = mockCopy.data[0].dimensions[0].label;

Plotly.plot(gd, mockCopy.data, mockCopy.layout).then(function() {
Plotly.plot(gd, mockCopy).then(function() {
expect(gd.data.length).toEqual(1);
expect(gd.data[0].dimensions.length).toEqual(2);
expect(document.querySelectorAll('.axis').length).toEqual(2);
Expand All @@ -434,7 +453,7 @@ describe('parcoords edge cases', function() {
}
}

Plotly.plot(gd, mockCopy.data, mockCopy.layout).then(function() {
Plotly.plot(gd, mockCopy).then(function() {
expect(gd.data.length).toEqual(1);
expect(gd.data[0].dimensions.length).toEqual(2);
expect(document.querySelectorAll('.axis').length).toEqual(2);
Expand All @@ -456,7 +475,7 @@ describe('parcoords edge cases', function() {
dim.values = [];
}

Plotly.plot(gd, mockCopy.data, mockCopy.layout).then(function() {
Plotly.plot(gd, mockCopy).then(function() {
expect(gd.data.length).toEqual(1);
expect(gd.data[0].dimensions.length).toEqual(2);
expect(document.querySelectorAll('.axis').length).toEqual(0);
Expand All @@ -482,7 +501,7 @@ describe('parcoords edge cases', function() {
}
}

Plotly.plot(gd, mockCopy.data, mockCopy.layout).then(function() {
Plotly.plot(gd, mockCopy).then(function() {
expect(gd.data.length).toEqual(1);
expect(gd.data[0].dimensions.length).toEqual(2);
expect(document.querySelectorAll('.axis').length).toEqual(2);
Expand Down Expand Up @@ -511,7 +530,7 @@ describe('parcoords edge cases', function() {
mockCopy.data[0].dimensions[i] = newDimension;
}

Plotly.plot(gd, mockCopy.data, mockCopy.layout).then(function() {
Plotly.plot(gd, mockCopy).then(function() {
expect(gd.data.length).toEqual(1);
expect(gd.data[0].dimensions.length).toEqual(60);
expect(document.querySelectorAll('.axis').length).toEqual(60);
Expand All @@ -537,7 +556,7 @@ describe('parcoords edge cases', function() {
mockCopy.data[0].dimensions[i] = newDimension;
}

Plotly.plot(gd, mockCopy.data, mockCopy.layout).then(function() {
Plotly.plot(gd, mockCopy).then(function() {
expect(gd.data.length).toEqual(1);
expect(gd.data[0].dimensions.length).toEqual(60);
expect(document.querySelectorAll('.axis').length).toEqual(60);
Expand All @@ -564,7 +583,7 @@ describe('parcoords edge cases', function() {
mockCopy.data[0].dimensions[i] = newDimension;
}

Plotly.plot(gd, mockCopy.data, mockCopy.layout).then(function() {
Plotly.plot(gd, mockCopy).then(function() {
expect(gd.data.length).toEqual(1);
expect(gd.data[0].dimensions.length).toEqual(60);
expect(document.querySelectorAll('.axis').length).toEqual(60);
Expand Down Expand Up @@ -595,7 +614,7 @@ describe('parcoords edge cases', function() {
mockCopy.data[0].dimensions[0] = 'This is not a plain object';
mockCopy.data[0].dimensions[1].values = 'This is not an array';

Plotly.plot(gd, mockCopy.data, mockCopy.layout).then(function() {
Plotly.plot(gd, mockCopy).then(function() {
expect(gd.data.length).toEqual(1);
expect(gd.data[0].dimensions.length).toEqual(5); // it's still five, but ...
expect(document.querySelectorAll('.axis').length).toEqual(3); // only 3 axes shown
Expand Down Expand Up @@ -921,7 +940,7 @@ describe('parcoords basic use', function() {
reversedMockCopy.data[0].dimensions.forEach(function(d) {d.id = 'R_' + d.id;});
reversedMockCopy.data[0].dimensions.forEach(function(d) {d.label = 'R_' + d.label;});

Plotly.plot(gd, reversedMockCopy.data, reversedMockCopy.layout).then(function() {
Plotly.plot(gd, reversedMockCopy).then(function() {
expect(gd.data.length).toEqual(2);

expect(gd.data[0].dimensions.length).toEqual(11);
Expand Down