Devtools overhaul - now with reloadng and search! #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| source = document.createElement('script'); | ||
| source.id = 'source'; | ||
| source.src = '../../build/plotly.js'; |
|
Oh man. This will make my life so much easier. Thanks for doing this 🎉 |
| </header> | ||
|
|
||
| <section id="mocks-list"></section> | ||
| <div id="plots"></div> |
There was a problem hiding this comment.
maybe the dashboard should start with a <div id="default-plot">. Thoughts?
There was a problem hiding this comment.
Sure. It's hard to tell others usage of the dashboard but I usually plot with Tabs.fresh() so it wasn't necessary.
|
|
||
| var PORT = process.argv[2] || 3000; |
|
@mdtusz looking great. One minor issue:
could you make the graph container scrollable in the horizontal so that we can see the color bar in e.g |
|
Interesting. I have the plot-containers being resized to match the width but I'll add an |
|
Awesome. Let's 💃 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just touches devtools and adds some niceties for testing stuff out.
Tabs.reload()- will tear down and re-load thePlotlyobject.Tabs.onReload- define a function onTabs.onReloadand it will be run wheneverTabs.reload()is called.Tabs.purge()- clear the testing area of all plots and images.Tabs.fresh(id)- create a new fresh plot with the specifiedid. Defaults to 'default-plot`Tabs.getGraph(id)- same as before but now you can grab a specific plot.Tabs.snapshot(id)- will create a snapshot of the specified plot