Add Float32Array eslint global #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes the reported eslint errors in `src/traces/surface/convert.js` and `src/traces/surface/convert.js`.
|
Is this necessary? I haven't seen As far as I know, eslint uses this list which indeed contains |
|
Perhaps there's something wrong with my setup. This is what I get when I run user@host:~/github/plotly.js$ npm run lint
> plotly.js@1.7.1 lint /home/user/github/plotly.js
> eslint . || true
/home/user/github/plotly.js/src/traces/scattergl/convert.js
48:24 error 'Float32Array' is not defined no-undef
64:24 error 'Float32Array' is not defined no-undef
65:21 error 'Float32Array' is not defined no-undef
75:24 error 'Float32Array' is not defined no-undef
76:21 error 'Float32Array' is not defined no-undef
86:24 error 'Float32Array' is not defined no-undef
218:8 error 'Float32Array' is not defined no-undef
219:35 error 'Float32Array' is not defined no-undef
270:25 error 'Float32Array' is not defined no-undef
326:45 error 'Float32Array' is not defined no-undef
332:41 error 'Float32Array' is not defined no-undef
355:25 error 'Float32Array' is not defined no-undef
356:23 error 'Float32Array' is not defined no-undef
357:23 error 'Float32Array' is not defined no-undef
448:45 error 'Float32Array' is not defined no-undef
454:41 error 'Float32Array' is not defined no-undef
494:42 error 'Float32Array' is not defined no-undef
517:41 error 'Float32Array' is not defined no-undef
/home/user/github/plotly.js/src/traces/surface/convert.js
104:30 error 'Float32Array' is not defined no-undef
140:41 error 'Float32Array' is not defined no-undef
186:25 error 'Float32Array' is not defined no-undef
187:25 error 'Float32Array' is not defined no-undef
188:25 error 'Float32Array' is not defined no-undef
255:37 error 'Float32Array' is not defined no-undef
✖ 24 problems (24 errors, 0 warnings)
|
|
Hmm. Weird. From the ./node_modules/.bin/eslint --version? |
user@host:~/github/plotly.js$ ./node_modules/.bin/eslint --version
v2.5.3 |
|
Ah. Nice find. I was running Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/traces/surface/convert.jsand
src/traces/surface/convert.js.