Better geo streaming #324
Merged
Better geo streaming #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove <g class="points"> (no need for an extra nested layer) - rm all inner node in <g class="trace scattergeo"> so that order line/marker/text ordering is kept
| }) | ||
| .on('mouseup', handleMouseOver); // ~ 'zoomend' | ||
|
|
||
| paths.exit().remove(); |
There was a problem hiding this comment.
previously, existing choropleth nodes were not removed.
|
💃 from me! |
|
Yep. If you're happy with the purge strategy then 💃 from me too. |
Yeah. I'm ok with it for now. I ran some quick benchmarks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mdtusz
This PR fixes a few issues that occur while streaming
scattergeoand (to a lesser degree)choroplethtraces. See the added tests. All of those cases were broken before these patches.Most of the issues were a result of our implementation of the
d3update pattern. Whereas cartesian traces are purged on everyPlotly.plotcall, geo traces used the classicd3update pattern but did not account for a few details. Namely, that scatter traces have multiple modes.