Skip to content

add eslint eol-last rule #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2016
Merged

add eslint eol-last rule #321

merged 2 commits into from
Mar 8, 2016

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Mar 8, 2016

@mdtusz

Quick PR. I noticed in this patch that npm run lint didn't catch the missing the \n at the end of the file.

"space-infix-ops": [0, {"int32Hint": false}],
"quotes": [2, "single"],
"dot-notation": [2, {"allowKeywords": false}],
"operator-linebreak": [2, "after"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule is already seen across the repo. It is now enforced.

@mdtusz
Copy link
Contributor

mdtusz commented Mar 8, 2016

💃

etpinard added a commit that referenced this pull request Mar 8, 2016
@etpinard etpinard merged commit c735931 into master Mar 8, 2016
@etpinard etpinard deleted the eslint-eol-last branch March 8, 2016 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants