Skip to content

add cors support for devtools http server #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Conversation

antoinerg
Copy link
Contributor

This allows talking to the devtools http server from any webpage. This enables my prototype image viewer (hosted on another domain) to retrieve mocks and images from localhost!

@antoinerg
Copy link
Contributor Author

BTW, here's a preview of that image viewer. It will fetch the list of mocks (as well as the images) from localhost:3000 provided the dev server is running from the current PR :)

@antoinerg antoinerg self-assigned this Oct 17, 2018
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks slick - and no problem to enable cors here 💃

@antoinerg antoinerg merged commit 33067fb into master Oct 17, 2018
@antoinerg antoinerg deleted the devtools-cors-support branch October 17, 2018 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants