-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Welsh UK locale formats type:translation #2877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Very nice @HywelMJ, thanks! I just linted a couple of whitespace issues. (though it's still complaining "incorrect header information" - @etpinard I don't see what's wrong, do you?) @HywelMJ do you want to try translating the text as well, or are you OK leaving this in English? There are examples here |
Added translation of terms in dictionary
Thanks very much @HywelMJ! Can you recommend another Welsh speaker who's able to review these?
Huh, now github seems confused about where this is coming from altogether, just says:
Might be easiest to just remake this as a PR from a local branch. I'm happy to do this (also the new dictionary needs indentation and some other whitespace) but lets see if we can find a reviewer for the dictionary first in this PR. |
Sorry, I'm getting a bit lost. I tried commenting: Here's the script I tried merging: |
No problem @HywelMJ - I'm happy to manage the mechanics. Not sure if I'll be able to do it in a way that preserves your authorship in the git history but I'll try! @carlmorris @illtud @meigwilym if one of you would review the items in |
Looks good to me. I may have used 'olin' for 'trace' rather than 'tres', but it's not a hill I'd die on. |
Happy to accept 'olin' |
superseded by #2945 |
Welsh UK locale formats
References: http://www.comisiynyddygymraeg.cymru/English/Part%203/10%20Locales%20alphabets%20and%20character%20sets/10.1%20Locales/Pages/10-1-3-Differences-between-British-English-and-British-Welsh-locales.aspx
http://www.unicode.org/cldr/charts/28/verify/dates/cy.html