Skip to content

Welsh UK locale formats type:translation #2877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Welsh UK locale formats type:translation #2877

wants to merge 4 commits into from

Conversation

@alexcjohnson
Copy link
Collaborator

Very nice @HywelMJ, thanks! I just linted a couple of whitespace issues. (though it's still complaining "incorrect header information" - @etpinard I don't see what's wrong, do you?)

@HywelMJ do you want to try translating the text as well, or are you OK leaving this in English? There are examples here

@etpinard
Copy link
Contributor

etpinard commented Aug 8, 2018

@etpinard I don't see what's wrong, do you?

Something was up when comparing newline characters \r\n vs \n, ac28c34 fixes that.

Now I can't seem to be able to push HywelMJ:master. Can someone either cherry-pick ac28c34 or open another PR from ac28c34?

@alexcjohnson
Copy link
Collaborator

do you want to try translating the text as well

Thanks very much @HywelMJ! Can you recommend another Welsh speaker who's able to review these?

Now I can't seem to be able to push HywelMJ:master. Can someone either cherry-pick ac28c34 or open another PR from ac28c34?

Huh, now github seems confused about where this is coming from altogether, just says:

HywelMJ wants to merge 4 commits into plotly:master from unknown repository

Might be easiest to just remake this as a PR from a local branch. I'm happy to do this (also the new dictionary needs indentation and some other whitespace) but lets see if we can find a reviewer for the dictionary first in this PR.

@HywelMJ
Copy link
Contributor Author

HywelMJ commented Aug 13, 2018

Sorry, I'm getting a bit lost. I tried commenting:
"I couldn't manage to merge PR #2877 so I forked again but I've added translation of chart term now.
Left translation of 'Pan' as 'Pan' as not sure how to translate. Some other terms are tentative but hopefully intelligible to Welsh speakers. @carlmorris @illtud @meigwilym may be able to help in reviewing"

Here's the script I tried merging:
cy.txt

@alexcjohnson
Copy link
Collaborator

alexcjohnson commented Aug 14, 2018

No problem @HywelMJ - I'm happy to manage the mechanics. Not sure if I'll be able to do it in a way that preserves your authorship in the git history but I'll try!

@carlmorris @illtud @meigwilym if one of you would review the items in dictionary here I'd be grateful - then I'll fix up the indentation and such and make a new PR.

@illtud
Copy link

illtud commented Aug 23, 2018

Looks good to me. I may have used 'olin' for 'trace' rather than 'tres', but it's not a hill I'd die on.

@alexcjohnson
Copy link
Collaborator

Thanks @illtud, really appreciate you taking the time to review! @HywelMJ let me know if you'd like to swap in 'olin' or keep 'tres', and then I'll make a new PR.

@HywelMJ
Copy link
Contributor Author

HywelMJ commented Aug 23, 2018

Happy to accept 'olin'

@alexcjohnson alexcjohnson mentioned this pull request Aug 27, 2018
@alexcjohnson
Copy link
Collaborator

superseded by #2945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants