Skip to content

Add Building.md #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 23, 2018
Merged

Add Building.md #2654

merged 7 commits into from
May 23, 2018

Conversation

etpinard
Copy link
Contributor

For centralized and complete building instructions to eventually cover ✨ all ✨ build frameworks.

This PR uses commits from @TomDemulierChevret's #2260

cc @alexcjohnson

TomDemulierChevret and others added 3 commits May 23, 2018 11:50
- move webpack instructions to BUILDING.md
- move (new) angular cli instruction to BUILDING.md
- fixup links
- add browserify instructions
README.md Outdated
@@ -20,6 +20,7 @@ and more.

* [Quick start options](#quick-start-options)
* [Modules](#modules)
* [Building plotly.js](##building-plotlyjs)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

## ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> b8e1bea

@alexcjohnson
Copy link
Collaborator

Looks good to me, thanks for doing this @etpinard ! If you're OK with my (small) changes, 💃

@etpinard etpinard merged commit b5de241 into master May 23, 2018
@etpinard etpinard deleted the building-instructions branch May 23, 2018 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants