Make deleteTrace handle big-indices-array properly [fixes #201] #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that 0,1, ... 11 are sorted as 11, 10, ... 0 instead of 1, 10, 11, 2, 3 ... 9
| @@ -31,6 +31,7 @@ lib.parseDate = datesModule.parseDate; | |||
| var searchModule = require('./search'); | |||
| lib.findBin = searchModule.findBin; | |||
| lib.sorterAsc = searchModule.sorterAsc; | |||
| lib.sorterDec = searchModule.sorterDes; | |||
There was a problem hiding this comment.
Decreasing or Descending?
We should keep it consistent with increasing/inc and decreasing/dec or ascending/asc and descending/des.
There was a problem hiding this comment.
Thanks good catch.
I was thinking of Descending. So sorterDes is OK? I have no preference.
There was a problem hiding this comment.
No preference here either. Descending probably makes a bit more sense though.
|
💃 Merge away. |
etpinard
changed the title
etpinard
added a commit
that referenced
this pull request
Jan 21, 2016
Make deleteTrace handle big-indices-array properly [fixes #201]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mdtusz @HungryGeneral