Skip to content

Update package.json #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2015
Merged

Update package.json #19

merged 2 commits into from
Nov 20, 2015

Conversation

Hypercubed
Copy link
Contributor

browserify and uglify-js should probably be devDependencies. Perhaps through2 as well.

@Hypercubed
Update package.json
9661c5f 
`browserify` and `uglify-js` should probably be `devDependencies`.  Perhaps `through2` as well.
@etpinard
Copy link
Contributor

browserify and uglify-js should probably be devDependencies

Absolutely.

All the necessary modules for building plotly.js were erroneously put in dependencies. My mistake.

Would you mind making through2, node-sass, fs-extra and xml2js devDependencies too?

@etpinard
Copy link
Contributor

EDIT (for above comment)

We still need fs-extra, node-sass and xml2js as dependencies as they are called on postinstall.

through2 can be safely taken out though.

@Hypercubed
Copy link
Contributor Author

I moved through2 to devDependencies.

@etpinard
Copy link
Contributor

Beautiful. Thanks for doing this.

etpinard added a commit that referenced this pull request Nov 20, 2015
@etpinard
Merge pull request #19 from Hypercubed/patch-1
78be916 
Update package.json
@etpinard etpinard merged commit 78be916 into plotly:master Nov 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hypercubed @etpinard