-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Split scatter module #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split scatter module #184
Conversation
- require individual steps in scatter3d, scattergeo, scattergl defaults.
- use it in attributes and default step
instead of require all of Scatter
By doing so, we get rid of two circular dependencies:
|
'use strict'; | ||
|
||
module.exports = { | ||
PTS_LINESONLY: 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slightly abusive, but it's the only way to clear us of circular dependencies while keeping things 🌴
Another thing to note, with this PR, no src file requires the full Scatter module (i.e. no files has That is, we can remove these lines in src/plotly.js. That said, should we make the pro users register the Scatter? I'd vote for yes. Its plot step is quite big. |
+1 for making pro users register all/any traces. |
I'd say that in |
This looks good to go though 💃 |
agreed. 👍 |
@mdtusz @cldougl @alexcjohnson