-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Make relayout work for scene.camera
#1364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- setting paperdiv style is done in the layoutStyles plot_api subroutine
- which calls scene.setCamera in relayout/update
- instead of hacky setCamera call - save 'initial' camera setting during scene creation - use that + relayout to set camera to last save - no need to emit plotly_relayout in setCamera no more!
ping @thejackluo , who was working a on remake of this NYT classic: |
mouseEvent('mousemove', start[0], start[1]); | ||
mouseEvent('mousedown', start[0], start[1], { buttons: 1 }); | ||
mouseEvent('mousemove', end[0], end[1], { buttons: 1 }); | ||
mouseEvent('mouseup', end[0], end[1]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this commit in a PR about 3D?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5f36071 broke the test w/o me noticing. As test cases that require a gl context are skipped on CI, this went unnoticed until now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Full disclosure, I actually noticed this broken test case twice before (when releasing 1.22.0
and 1.23.0
), but I was too lazy and didn't feel like making a PR just for that.
Very nice, much cleaner. 💃 |
fixes #934
so that http://codepen.io/monfera/pen/KMmPPV can now use
Plotly.relayout
asinstead of digging into the
scene
object internals.In addition,
relayout
work forscene.camera
we can now rewrite the 3d camera modebar handlers in a much cleaner way 604f7a0docamera
is added in 99ad3cb