Ensure empty candlestick traces don't lead to autotyped 'category' x-axis #1359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- box traces have a special algo to handle the case where trace 'name' can appear on axis ticks.
etpinard
commented
Feb 7, 2017
src/plots/cartesian/axis_defaults.js
Outdated
| @@ -207,6 +207,7 @@ function isBoxWithoutPositionCoords(trace, axLetter) { | |||
|
|
|||
| return ( | |||
| Registry.traceIs(trace, 'box') && | |||
| trace._fullInput.type === 'box' && | |||
There was a problem hiding this comment.
See https://github.com/plotly/streambed/pull/3236 for the details on why axis auto type with box traces needs more attention.
I'm debating whether we should add a fallback here for _fullInput ?
etpinard
commented
Feb 7, 2017
| var trace0 = { type: 'candlestick' }; | ||
| var out = _supply([trace0], { xaxis: {} }); | ||
|
|
||
| expect(out._fullLayout.xaxis.type).toEqual('linear'); |
There was a problem hiding this comment.
Before this patch, this assertions resulted in 'category'.
|
💃 tested on streambed and this fixes the grouping problem! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1357