Calendar fixes #1252
Merged
Calendar fixes #1252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix world cals tickformat support - fix some weird rounding edge cases - fix our special %f formatter when it's used more than once
|
Looking good. Great tests 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@etpinard can we get this out as a patch release and in streambed ASAP? Fixes the two world calendar bugs we found:
ms2DateTimemisinterpreted all month 1's as intercalary: @n-riesco fixed this in Fix false intercalary first month alexcjohnson/world-calendars#9 and here I bumpedworld-calendarsto 1.0.2tickformatwas broken with world calendars - this fixes it, and testsLib.formatDate.Also cleans up a few weird edge cases that popped up while writing the tests.