-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Apply trace opacity to 'mode: 'lines' legend items #1204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5788fa7
legend: apply trace opacity to line legend items
etpinard ee53da3
test: add trace opacity to line scatter mock
etpinard 1820f14
test: update baseline with line opacity legend items
etpinard 7a807f6
Merge branch 'master' into legend-line-opacity
etpinard d009798
group legend item layers in one <g> and apply trace.opacity on it
etpinard 849782d
improve line_scatter mock
etpinard bc15f67
AJ-proof line_scatter mock
etpinard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,10 @@ | |
17 | ||
], | ||
"mode": "markers", | ||
"type": "scatter" | ||
"type": "scatter", | ||
"marker": { | ||
"opacity": 0.5 | ||
} | ||
}, | ||
{ | ||
"x": [ | ||
|
@@ -30,7 +33,8 @@ | |
9 | ||
], | ||
"mode": "lines", | ||
"type": "scatter" | ||
"type": "scatter", | ||
"opacity": 0.5 | ||
}, | ||
{ | ||
"x": [ | ||
|
@@ -46,7 +50,18 @@ | |
12 | ||
], | ||
"mode": "lines+markers", | ||
"type": "scatter" | ||
"type": "scatter", | ||
"opacity": 0.707, | ||
"marker": { | ||
"opacity": 0.707 | ||
} | ||
}, | ||
{ | ||
"x": [1, 2, 3], | ||
"y": [1, 2, 3], | ||
"opacity": 0.2, | ||
"line": { "width": 10, "color": "red"}, | ||
"marker": { "size": 20, "color": "blue"} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Beautiful, thanks :) 💃 |
||
} | ||
] | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be a better test to set the opacity on a lines+markers trace - which I don't think is handled correctly in this PR, trace opacity should get set on
traceGroup
rather than independently to lines and markers (and fills!).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, see
that would imply that the trace name (rendered in the
<text class="legendtext">
node) would be semi-transparent whenevertrace.opacity < 1
.So, in d009798 a new
<g>
is added grouping the fill, lines and symbols<g>
and applyingtrace.opacity
once.