Add npm ls check and dist log file #1095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- npm ls exits with code 1 (i.e. errors out) when a unmet dependencies are present in node_modules/ - use this to as a sanity check before versioning and bundling
- to log exactly what package version used when bundling dist files - output file is dist/npm-ls.json and will be checked in during `npm version`
etpinard
commented
Oct 27, 2016
| if(common.doesFileExist(pathDistNpmLs)) fs.unlinkSync(pathDistNpmLs); | ||
|
|
||
| var ws = fs.createWriteStream(pathDistNpmLs, { flags: 'a' }); | ||
| var proc = spawn('npm', ['ls', '--json', '--only', 'prod']); |
There was a problem hiding this comment.
Note that npm ls --json essentially logs an npm-shrinkwrap json file.
|
TODO
|
|
Interesting behaviour of 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most recent minor version bump (
v1.19.0) featured many dependency bumps. To make sure that I had the correctnode_modulestree I rannpm ls. That's when I realised thatnpm lscompletes with exit code1whenever unmet dependencies are present in the localnode_module. So, why not use this as a preversion check? That way we'll enforce whoever bumps the version to have the correctnode_modulestree.Moreover, I'm thinking that we should log the
node_modulestree structure indist/whenever for produce new dist bundles. That way troubleshooting possiblemasteranddistbundle mismatch should be a lot easier. This is especially important with the recent and planned short-term gl2d development where a lot of gl-vis module were patched.