Handle actual zero values as other numbers rather than as unsupplied #1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…", null, NaN) except if it's false or undefined
monfera
changed the title
etpinard
suggested changes
Oct 5, 2016
| @@ -33,7 +33,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout | |||
|
|
|||
| var contourStart = Lib.coerce2(traceIn, traceOut, attributes, 'contours.start'), | |||
| contourEnd = Lib.coerce2(traceIn, traceOut, attributes, 'contours.end'), | |||
| autocontour = coerce('autocontour', !(contourStart && contourEnd)); | |||
| autocontour = coerce('autocontour', contourStart === false || contourEnd === false); | |||
There was a problem hiding this comment.
Great. @monfera would you mind adding a test case for this in the contour_test.js suite?
|
done in #1280 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lib.coerce2 to return original value for 0, "", NaN, null rather than false
Perform logic such that a specified zero value doesn't mean false in the
contourlogic