Test mock with unexpected "barnorm" value

[hmf]

The mock bar_attrs_overlay.json has the following layout:

    "layout":{
        "xaxis": {"showgrid":true},
        "height":400,
        "width":400,
        "barmode":"overlay",
        "barnorm":false
    }

Testing based on the schema resulted in a parsing error of "barnorm". The schema has:

"barnorm": {
                    "valType": "enumerated",
                    "values": [
                        "",
                        "fraction",
                        "percent"
                    ],
                    "dflt": "",
                    "role": "info",
                    "editType": "calc",
                    "description": "Sets the normalization for bar traces on the graph. With *fraction*, the value of each bar is divided by the sum of all values at that location coordinate. *percent* is the same but multiplied by 100 to show percentages."
                },

Is that an error or can we have false values?

TIA

[archmoj]

Some attributes could be set to false.
But in this case false is not among those valid options for barnorm.
So the dflt value would be used which is blank string ( "" ).

[hmf]

So I can consider this value incorrect? The reason I ask is explained in this
#4705 (comment).

Apologies for insisting so much but auto-generating code from the schema is not trivial for me.

[alexcjohnson]

That's an error, good catch! In fact, layout.barnorm isn't even used in that mock, because it has barmode: 'overlay'

plotly.js/src/traces/bar/layout_defaults.js

Line 54 in 0e01a5a

if(mode !== 'overlay') coerce('barnorm');

So we should just remove that line from the mock.

[hmf]

Ok. I will set it to "" in my tests and update the mock to latest changes when available. Thanks.