Skip to content

Make sure TypedArrays are supported everywhere #3215

Closed
@alexcjohnson

Description

@alexcjohnson

Discussion from #3210:

(@alexcjohnson) I'll fix (and test) this specific bug, but @etpinard I'm not sure what would make a good generic test of typed array support - in principle we could rerun the entire image test suite, combing through data (and layout for numeric arrays and converting them to typed arrays first... that seems pretty heavy but how else could we catch silent bugs like this?

(@etpinard) That does seems pretty heavy, unless we can add two more CircleCI test containers 💰

But maybe we could try to run all our mocks with typed arrays once locally and then lock failing cases (if any 😏 ) with jasmine tests.

And how do we catch these problems in new features then? I guess if there's a simple command to run all of our mocks with TypedArrays, we could make this part of the pre-publish checklist?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions