Sankey nodes overlap by default

[rahul-ldn]

Hi there,

As you can see here, a relatively simply sankey will often end up with nodes overlapping with other nodes, and the outgoing flows stacked as well. The code generating this diagram can be found here

Is there a reason this is happening?

Thanks!
R

[etpinard]

Thanks for the report.

[rahul-ldn]

Update: It appears to be browser-specific; Chrome 65 has this issue, but the diagram renders properly on Safari 11 (both on Mac OS 10.13 High Sierra)

[alexcjohnson]

And yet a different result in FF (image is Chrome / FF / Safari):

Here it is as a pared-down codepen https://codepen.io/alexcjohnson/pen/NMdMbE?editors=1010
Even in Safari it's not quite right - there is no overlap at least, but there's a net upward shift from left to right that should not be there.

[alexcjohnson]

Update: the issue here is with a link with value: 0 (element 5 in this graph's link.value array, that leads to node 15 having zero size). If I replace that with anything positive the layout is fixed. The zero results in a NaN in the node list, and I suspect the breakage and the browser-dependence of the problem have to do with strange handling of NaN in Array.sort or the like.

Obviously we need to prevent a zero (or otherwise invalid) value from breaking things, but the question then is, what should this do? Should we delete it completely? Draw it as a very thin node & link (labeled as size zero)?

Negative or non-numeric values I feel confident we should ignore, but I feel like there may be cases you still want a zero-size node to show up. Thoughts?