Skip to content

Commit a4285e5

Browse files
committed
do not catch failTest in beforeEach blocks
1 parent 97574f9 commit a4285e5

9 files changed

+1
-18
lines changed

test/jasmine/tests/animate_test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ describe('Test animate API', function() {
106106

107107
Plotly.plot(gd, mockCopy.data, mockCopy.layout).then(function() {
108108
return Plotly.addFrames(gd, mockCopy.frames);
109-
}).catch(failTest).then(done);
109+
}).then(done);
110110
});
111111

112112
afterEach(function() {

test/jasmine/tests/cartesian_interact_test.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ describe('zoom box element', function() {
3232
mockCopy.layout.dragmode = 'zoom';
3333

3434
Plotly.plot(gd, mockCopy.data, mockCopy.layout)
35-
.catch(failTest)
3635
.then(done);
3736
});
3837

test/jasmine/tests/gl3d_plot_interact_test.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -472,7 +472,6 @@ describe('Test gl3d modebar handlers - perspective case', function() {
472472
.then(function() {
473473
modeBar = gd._fullLayout._modeBar;
474474
})
475-
.catch(failTest)
476475
.then(done);
477476
});
478477

@@ -763,7 +762,6 @@ describe('Test gl3d modebar handlers - orthographic case', function() {
763762
.then(function() {
764763
modeBar = gd._fullLayout._modeBar;
765764
})
766-
.catch(failTest)
767765
.then(done);
768766
});
769767

test/jasmine/tests/parcoords_test.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -926,7 +926,6 @@ describe('parcoords basic use', function() {
926926
if(!hasGD) gd = createGraphDiv();
927927

928928
Plotly.react(gd, mockCopy)
929-
.catch(failTest)
930929
.then(done);
931930
});
932931

@@ -1211,7 +1210,6 @@ describe('parcoords react more attributes', function() {
12111210
if(!hasGD) gd = createGraphDiv();
12121211

12131212
Plotly.react(gd, mock3)
1214-
.catch(failTest)
12151213
.then(done);
12161214
});
12171215

@@ -1380,7 +1378,6 @@ describe('parcoords constraint interactions - without defined axis ranges', func
13801378
checkDashCount(initialDashArray1, 1);
13811379
}
13821380
})
1383-
.catch(failTest)
13841381
.then(done);
13851382
});
13861383

@@ -1646,7 +1643,6 @@ describe('parcoords constraint interactions - with defined axis ranges', functio
16461643
if(!hasGD) gd = createGraphDiv();
16471644

16481645
Plotly.react(gd, initialFigure())
1649-
.catch(failTest)
16501646
.then(done);
16511647
});
16521648

@@ -1729,7 +1725,6 @@ describe('parcoords constraint click interactions - with pre-defined constraint
17291725
if(!hasGD) gd = createGraphDiv();
17301726

17311727
Plotly.react(gd, initialFigure())
1732-
.catch(failTest)
17331728
.then(done);
17341729
});
17351730

test/jasmine/tests/plot_api_test.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2761,7 +2761,6 @@ describe('Test plot api', function() {
27612761
layout = gd.layout;
27622762
calcdata = gd.calcdata;
27632763
})
2764-
.catch(failTest)
27652764
.then(done);
27662765
});
27672766

test/jasmine/tests/range_selector_test.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,6 @@ describe('range selector interactions:', function() {
467467
mockCopy = Lib.extendDeep({}, mock);
468468

469469
Plotly.plot(gd, mockCopy.data, mockCopy.layout)
470-
.catch(failTest)
471470
.then(done);
472471
});
473472

@@ -636,7 +635,6 @@ describe('range selector automargin', function() {
636635
}});
637636

638637
Plotly.plot(gd, mockCopy.data, mockCopy.layout)
639-
.catch(failTest)
640638
.then(done);
641639
});
642640

test/jasmine/tests/scattergeo_test.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,6 @@ describe('Test scattergeo hover', function() {
314314
lat: [10, 20, 30],
315315
text: ['A', 'B', 'C']
316316
}])
317-
.catch(failTest)
318317
.then(done);
319318
});
320319

test/jasmine/tests/template_test.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,6 @@ describe('template interactions', function() {
216216
var mock = Lib.extendDeep({}, templateMock);
217217
gd = createGraphDiv();
218218
Plotly.newPlot(gd, mock)
219-
.catch(failTest)
220219
.then(done);
221220
});
222221
afterEach(destroyGraphDiv);

test/jasmine/tests/updatemenus_test.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,6 @@ describe('update menus buttons', function() {
280280
dropdownMenus = allMenus.filter(function(opts) { return opts.type !== 'buttons'; });
281281

282282
Plotly.plot(gd, mockCopy.data, mockCopy.layout)
283-
.catch(failTest)
284283
.then(done);
285284
});
286285

@@ -322,7 +321,6 @@ describe('update menus initialization', function() {
322321
]
323322
}]
324323
})
325-
.catch(failTest)
326324
.then(done);
327325
});
328326

@@ -353,7 +351,6 @@ describe('update menus interactions', function() {
353351
mockCopy.layout.updatemenus[1].x = 1;
354352

355353
Plotly.plot(gd, mockCopy.data, mockCopy.layout)
356-
.catch(failTest)
357354
.then(done);
358355
});
359356

@@ -1092,7 +1089,6 @@ describe('update menus interaction with scrollbox:', function() {
10921089
menuRight = menus[3];
10931090
menuUp = menus[4];
10941091
})
1095-
.catch(failTest)
10961092
.then(done);
10971093
});
10981094

0 commit comments

Comments
 (0)