Skip to content

Commit 97574f9

Browse files
committed
fixup annotations_test
1 parent efee80b commit 97574f9

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

test/jasmine/tests/annotations_test.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -430,13 +430,15 @@ describe('annotations relayout', function() {
430430
{'annotations[0]': 'not an object'},
431431
{'annotations[100]': {text: 'bad index'}}
432432
].forEach(function(update) {
433-
it('warns on ambiguous combinations and invalid values: ' + JSON.stringify(update), function() {
433+
it('warns on ambiguous combinations and invalid values: ' + JSON.stringify(update), function(done) {
434434
Plotly.relayout(gd, update)
435435
.then(function() {
436436
expect(Loggers.warn).toHaveBeenCalled();
437437
// we could test the results here, but they're ambiguous and/or undefined so why bother?
438438
// the important thing is the developer is warned that something went wrong.
439-
});
439+
})
440+
.catch(failTest)
441+
.then(done);
440442
});
441443
});
442444

@@ -510,7 +512,7 @@ describe('annotations log/linear axis changes', function() {
510512
var mockData = Lib.extendDeep([], mock.data);
511513
var mockLayout = Lib.extendDeep({}, mock.layout);
512514

513-
return Plotly.plot(gd, mockData, mockLayout).then(done);
515+
Plotly.plot(gd, mockData, mockLayout).then(done);
514516
});
515517

516518
afterEach(destroyGraphDiv);

0 commit comments

Comments
 (0)