Skip to content

Commit 7cc4368

Browse files
committed
Merge pull request #477 from plotly/etpinard-patch-2
add info about 'making pull requests'
2 parents 4f8f055 + ea047ba commit 7cc4368

File tree

1 file changed

+23
-3
lines changed

1 file changed

+23
-3
lines changed

CONTRIBUTING.md

Lines changed: 23 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,31 @@ community.plot.ly (tagged [`plotly-js`](http://community.plot.ly/c/plotly-js)) o
1515
[`plotly`](https://stackoverflow.com/questions/tagged/plotly)).
1616

1717
Comments on GitHub issues or pull requests should add content to the discussions.
18-
Approbation comments such as *+1* or *I would like this feature to be implemented as well* will be deleted by the maintainers. Please use [GitHub reactions](https://github.com/blog/2119-add-reactions-to-pull-requests-issues-and-comments) instead.
18+
Approbation comments such as *+1* or *I would like this feature to be implemented as well*
19+
will be deleted by the maintainers. Please use
20+
[GitHub reactions](https://github.com/blog/2119-add-reactions-to-pull-requests-issues-and-comments)
21+
instead.
1922

20-
## Issue labels
23+
## Making pull requests
2124

22-
We use the following [labels](https://github.com/plotly/plotly.js/labels) to track issues:
25+
Developers are strongly encouraged to first make a PR to their own plotly.js
26+
fork and ask one of the maintainers to review the modifications there. Once the
27+
pull request is deemed satisfactory, the developer will be asked to make a pull
28+
request to the main plotly.js repo and may be asked to squash some commits
29+
before doing so.
30+
31+
Developers should `git rebase` their local branch off the latest `master` before
32+
opening a pull request.
33+
34+
Note that it is forbidden to force push (i.e. `git push -f`) to remote branches
35+
associated with opened pull requests. Force pushes make it hard for maintainers
36+
to keep track of updates. Therefore, if required, please
37+
`git merge master` into your PR branch instead of `git rebase master`.
38+
39+
40+
## GitHub labels
41+
42+
We use the following [labels](https://github.com/plotly/plotly.js/labels) to track issues and PRs:
2343

2444
| Label | Purpose |
2545
|--------|---------|

0 commit comments

Comments
 (0)