Skip to content

Commit ea047ba

Browse files
committed
add note about git rebase before making a PR
1 parent 758fbad commit ea047ba

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

CONTRIBUTING.md

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,18 @@ pull request is deemed satisfactory, the developer will be asked to make a pull
2828
request to the main plotly.js repo and may be asked to squash some commits
2929
before doing so.
3030

31-
It is forbidden to force push (i.e. `git push -f`) to remote branches
31+
Developers should `git rebase` their local branch off the latest `master` before
32+
opening a pull request.
33+
34+
Note that it is forbidden to force push (i.e. `git push -f`) to remote branches
3235
associated with opened pull requests. Force pushes make it hard for maintainers
33-
to keep track of updates. Therefore, if required, please `git merge
34-
master` into your PR branch instead of `git rebase master`.
36+
to keep track of updates. Therefore, if required, please
37+
`git merge master` into your PR branch instead of `git rebase master`.
3538

3639

37-
## Issue labels
40+
## GitHub labels
3841

39-
We use the following [labels](https://github.com/plotly/plotly.js/labels) to track issues:
42+
We use the following [labels](https://github.com/plotly/plotly.js/labels) to track issues and PRs:
4043

4144
| Label | Purpose |
4245
|--------|---------|

0 commit comments

Comments
 (0)