Disambiguate classnames #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the class of the plot_ly object (built but not widgetized) to plotly_hash, and simplify print/knit_print methods. This fixes compatibility issues with RStudio's upcoming R Notebook feature.
| #' @param ... additional arguments | ||
| #' @export | ||
| knit_print.plotly_built <- knit_print.plotly_hash | ||
|
|
There was a problem hiding this comment.
@jcheng5 I've been meaning to distinguish between "non-built" (e.g., plot_ly()) and "built" (e.g., plotly_build(plot_ly()) plotly objects for a while now. I haven't needed it up until this point since plotly_build() is idempotent (i.e., building a plot more than once should be the same as building it once). That being said, going forward I think it's a good idea to explicitly distinguish between these two types of objects.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.