solution for #463 plotly in ioslides #523
Closed
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this looks good. Some tests are failing because you don't have my credentials :P |
|
In the future, would you mind sending pull requests from this remote instead of your fork? |
|
Oh, makes sense. Sorry and will do going forward. |
|
I wonder if the credential issue will resolve itself in that case...would you mind resending from the ropensci remote? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull represents the most minimal solution possible to #463, so tooltips will appear in
ioslidespresentations. I tested with various examples in different contexts and did not notice any harmful regressions or side effects.