Add sharing argument and deprecate world_readable. Fixes #332 #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| url <- paste0(get_domain("v2"), "files/", verify("username"), ":", plot_id) | ||
| bod <- list(share_key_enabled = TRUE) | ||
| con2 <- httr::PATCH(url, plotly_headers("v2"), body = bod, encode = "json") | ||
| con$url <- paste0(con$url, "?share_key=", content(con2)$share_key) |
There was a problem hiding this comment.
@chriddyp is there anything else from the PATCH response that you'd like to return?
|
looks good to me! @delekru and I have been trying to come up with better names for "secret". Some options include: "hidden" or "unlisted". I think "unlisted" explains the behaviour the best. Thoughts? |
|
Thanks! No strong preference. I think I prefer 'unlisted'...how about 'key'? |
|
But my friend prefers "hidden", so I'm open. I think the "key" thing is confusing to folks that aren't developers |
|
OK, go ahead with 'hidden'? After thinking about more, I think I like hidden too. |
cpsievert
added a commit
that referenced
this pull request
Jan 19, 2016
Add sharing argument and deprecate world_readable. Fixes #332
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.