Dplyr 1.0 #1821
Merged
Dplyr 1.0 #1821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, all tests passed without catching this mistake, but I think I should have had a !! here.
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
As is done here https://github.com/r-lib/rlang/blob/64df8e3f/R/compat-lazyeval.R#L51 Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
cpsievert
force-pushed
the
dplyr-1.0
branch
2 times, most recently
from
50a300b to
79dc89a
Compare
cpsievert
commented
Jul 21, 2020
schloerke
reviewed
Jul 22, 2020
schloerke
reviewed
Jul 24, 2020
schloerke
reviewed
Jul 24, 2020
schloerke
reviewed
Jul 24, 2020
schloerke
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1783, #1825, and #1799